feat:레슨수정강사용 #108
Merged
feat:레슨수정강사용 #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Ji-minhyeok
approved these changes
Jul 18, 2025
| } | ||
|
|
||
| //레슨 이름 수정 | ||
| public void updateLessonName(String lessonName) { |
Collaborator
There was a problem hiding this comment.
setter 없이 적절하게 설계된 것 같습니다.
requestDto를 받아 update()메서드로 수정 메서드들을 하나로 묶는 방법도 있을 것 같습니다!
Collaborator
Author
There was a problem hiding this comment.
update()메서드안에서 조건에 대한 검증을 또 해야 되는데 이방법이 더 복잡해 질것 같아서 개별 메소드로 설계하였습니당!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ 작업 내용
강사용 레슨 수정 구현 완료했습니다.
스웨거에서 테스트 모두 완료 하였습니다.
patch를 통해서 수정하고 싶은값만 수정 가능하도록 테스트 완료 하였스빈다.
✅ PR 유형
✅ Check List
🔗 관련 이슈
💬 기타 참고 사항